Improves check for catphotoapp.com in 'Link to External Pages with Anchor Elements' #938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuincyLarson
pushed a commit
that referenced
this pull request
Jun 19, 2015
Improves check for catphotoapp.com in 'Link to External Pages with Anchor Elements'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the test case look for the case-insensitive "http://catphotoapp.com" instead of just "com" in the anchor's href attribute. I chose to use the global, case-insensitive regex instead of just
$('a').attr('href') === 'http://catphotoapp.com'because it gives the user a bit more freedom (see trailing backslashes etc.) and I've seen it used in other test cases. Let me know if you want a stricter or looser test and I'll change it.Fixes #914.