Update PR Template #9447
Update PR Template #9447
Conversation
raisedadead
added
the
status: waiting review
| @@ -5,23 +5,23 @@ | |||
| <!-- Make sure that your PR is not a duplicate --> | |||
|
|
|||
| #### Pre-Submission Checklist | |||
| <!-- Go over all points below, and put an `x` in all the boxes that apply. --> | |||
| <!-- All points should be checked, otherwise, read the CONTRIBUTING guidelines from above--> | |||
| <!-- Go over all points below, and after creating the PR click on all the check boxes that apply. --> | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
ghost
self-assigned this
ghost
added
status: blocked
|
@raisedadead updated the pull request. |
raisedadead
added
status: waiting review
| @@ -5,23 +5,23 @@ | |||
| <!-- Make sure that your PR is not a duplicate --> | |||
|
|
|||
| #### Pre-Submission Checklist | |||
| <!-- Go over all points below, and put an `x` in all the boxes that apply. --> | |||
| <!-- All points should be checked, otherwise, read the CONTRIBUTING guidelines from above--> | |||
| <!-- Go over all points below, and after creating the PR, click on all the checkboxes that apply. --> | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
@raisedadead updated the pull request. |
|
@raisedadead how common is the leading/trailing space issue? Contributors should be checking these boxes as they prep the PR. I feel like asking them to first create the PR, then to go back through and check the boxes will result in them cancelling PRs once they realize they didn't do something, or labeling more PRs WIP, etc. |
|
@QuincyLarson, sorry to answer something that's not my question, but the issue is very common. |
|
@QuincyLarson yeah, as @atjonathan mentioned already its pretty common, GitHub's feature is rather neat, while the markdown syntax just confuses new contributors. |
LGTM 👍Thanks ninja 🎉 |
ghost
merged commit 
BerkeleyTrue
removed
the
status: waiting review
New contributors left spaces in the
[ x]which did not render properly, rather having the contributors click on the check boxes is a better option, since GitHub now supports it.