Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

made output for sum and subtraction consistent with product #9492

Merged
merged 1 commit into from
Jul 2, 2016

Conversation

aksinghdce
Copy link
Contributor

@aksinghdce aksinghdce commented Jul 1, 2016

Pre-Submission Checklist

  • Your pull request targets the staging branch of FreeCodeCamp.
  • Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
  • You have only one commit (if not, squash them into one commit).
  • All new and existing tests pass the command npm run test-challenges. Use git commit --amend to amend any fixes.

Type of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Add new translation (feature adding new translations)

Checklist:

Description

@BerkeleyTrue BerkeleyTrue added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Jul 1, 2016
@aksinghdce
Copy link
Contributor Author

Done :)

@raisedadead
Copy link
Member

Hi @aksinghdce

Thanks a lot for the fix and the pull request!

Couple of points to note:

Can you replace the XXXX in the PR description with the issue no 9481.

Closes currently open issue (replace XXXX with an issue no): Closes #9481

This will auto close the issue when this PR is accepted. Also next time do not mention the issue no in the branch name, rather have a short name like fix/challenge-name

@aksinghdce
Copy link
Contributor Author

@raisedadead
I noted your comments and changed the description.
Next time I will use appropriate branch name.

Thanks

@raisedadead
Copy link
Member

@aksinghdce Thanks a lot for the changes.

✨ ✨ LGTM. ✨ ✨

Congratulations for your first contribution to Free Code Camp, looking forward to more contributions in future.

Happy fixing!

@raisedadead raisedadead merged commit 1e6c32c into freeCodeCamp:staging Jul 2, 2016
@raisedadead raisedadead removed the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Jul 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants