Add test for Smallest Common Multiple #9575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BerkeleyTrue
added
the
status: waiting review
✨ ✨ LGTM. ✨ ✨Thanks @BKinahan ! |
raisedadead
removed
the
status: waiting review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-Submission Checklist
stagingbranch of FreeCodeCamp.fix/npm run test-challenges.Type of Change
Checklist:
Description
Adds a new test for Smallest Common Multiple, with input
[23,18]. Solution code from both the Wiki and seed provide the correct output in testing, and the incorrect code in #7292 does not. (Tests now include a case which does not have 1 as the low end of the range)