Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/UPDATE-advanced-ziplines.json #9783

Merged
merged 1 commit into from
Jul 19, 2016
Merged

fix/UPDATE-advanced-ziplines.json #9783

merged 1 commit into from
Jul 19, 2016

Conversation

jwoo92
Copy link
Contributor

@jwoo92 jwoo92 commented Jul 18, 2016

Pre-Submission Checklist

  • Your pull request targets the staging branch of FreeCodeCamp.
  • Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
  • You have only one commit (if not, squash them into one commit).
  • All new and existing tests pass the command npm run test-challenges. Use git commit --amend to amend any fixes.

Type of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Add new translation (feature adding new translations)

Checklist:

  • Tested changes locally.
  • Closes currently open issue (replace XXXX with an issue no): Closes #XXXX

Description

Calculator project example update:

Previous calculator had several bugs that were addressed. Per Quincy Larson's request, this file has been updated to provide a new calculator example existing under Free Code Camp's CodePen profile that has corrected the following bugs in the previous calculator example:

  1. Entry box is now limited so all numbers / operations in use are visible.
  2. Corrected the use of operators - now you can not begin with an operator or use an operator twice in a row.
  3. Corrected the use of the decimal - now you can only use the decimal once per number to be evaluated.
  4. Corrected the use of zero - you now may not begin with or use multiple zeros unless it is in relation to a number with a decimal.
  5. Corrected a bug where once you received an answer, you may continue using the answer in another equation.
  6. Corrected a Clear Entry (CE) bug where once an equation's answer is returned, it does not All Clear (AC) if 'CE' is clicked.

Calculator project example update:

Previous calculator had several bugs that were addressed. Per Quincy Larson's request, this file has been updated to provide a new calculator example existing under Free Code Camp's CodePen profile that has corrected the following bugs in the previous calculator example:

Entry box is now limited so all numbers / operations in use are visible.
Corrected the use of operators - now you can not begin with an operator or use an operator twice in a row.
Corrected the use of the decimal - now you can only use the decimal once per number to be evaluated.
Corrected the use of zero - you now may not begin with or use multiple zeros unless it is in relation to a number with a decimal.
Corrected a bug where once you received an answer, you may continue using the answer in another equation.
Corrected a Clear Entry (CE) bug where once an equation's answer is returned, it does not All Clear (AC) if 'CE' is clicked.
@camperbot
Copy link
Contributor

@jwoo92 thanks for the PR.
Your branch name should start with one of fix/, feature/, translate/ prefixes. Name, your branches correctly next time, please.
Please, review our Guidelines for Contributing, thank you!.

@BerkeleyTrue BerkeleyTrue added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Jul 18, 2016
@QuincyLarson
Copy link
Contributor

@jwoo92 thank you for taking the time to identify these issues and address them in your CodePen pen. For archival purposes, @jwoo92 and I corresponded in Gitter and I forked his pen to FCC's account, which this challenge will now point to.

@QuincyLarson QuincyLarson merged commit ca02833 into freeCodeCamp:staging Jul 19, 2016
@QuincyLarson QuincyLarson removed the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Jul 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants