Implement middleware for admin views #733
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add AdminMiddleware to deny non admin users - Add decorator to mark views as "non admin"
|
This is still a work in progress. Not ready for a merge yet. |
- This fixes the redirect to the index page instead of apps:index post login
- This makes the user update and password change pages non admin so that non admin users can access
|
This can now be merged. |
- This checks that the user making the request is the same user as the one logged in and prevents access to the pages of other users if its not admin
- This adds OpenVPN icon - This enables the OpenVPN app on the index page. - This allows only admins to create the certs for OpenVPN and admins and non admins can not download their own profiles via the app icon.
|
Feature Hopefully Complete. 😄 |
Closed
- Only admins can now edit the groups of any user - Only admins can mark any user as active or not - Refactored all occurrences of admin checks to its own utility function
|
Congratulations on your first contribution to the FreedomBox project :) . I have merged these patches with some fixes and updates. Please see my changes as review comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in reference to the bug #426
This adds the middleware needed to intercept requests to admin areas and treats all non public views as admin unless decorated as "non admin"