-
Notifications
You must be signed in to change notification settings - Fork 4
Conversation
Specifically, addresses safety id 38834, affecting urllib3 <1.25.9.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pip-tools
will probably have to be updated as well for subsequent runs of pip-compile
to work. The version installed is 3.7.0, which is not compatible with latest pip. Pinning it to >5.0.0 would probably do the trick.
In order for pip-compile to work, as suggested by @zenmonkeykstop
Nice find, thanks both! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change is good. safety
check passes. 🦄
I can not merge this PR (no permission). So, someone else has to do this. |
Thanks @kushaldas, merging now, since both you and @emkll have approved. Will work on straightening out the access list separately. |
Addressed by others, and re-approved by others
Specifically, addresses safety id 38834, affecting urllib3 <1.25.9.
safety check -r requirements.txt
shows "No known security vulnerabilities found".