Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "Change selection" button near "x document(s) selected" #428

Closed
eloquence opened this issue May 25, 2023 · 0 comments · Fixed by #439
Closed

Add "Change selection" button near "x document(s) selected" #428

eloquence opened this issue May 25, 2023 · 0 comments · Fixed by #439
Assignees
@deeplow
Labels
enhancement New feature or request
Milestone
0.4.2

Comments

@eloquence
Copy link
Member

eloquence commented May 25, 2023 •
edited by deeplow

User story

If I'm unsure if I've selected the right file for conversion, or if I've definitely selected the wrong one, I want to be able to change my selection, so that I'm not converting the wrong file.

Background

Ideally we'll have a progressive disclosure display of all selected files, but as an immediate step, we've discussed previously that this would be a significant improvement already that does not require UX work.

Notes / Evidence (added by @deeplow)

During user testing, a participant wanted to change the document selection because they had clicked on the wrong document but they couldn't. Restarting the application turned out the be the only way to do so.
@eloquence eloquence added the enhancement New feature or request label May 25, 2023
@deeplow deeplow added this to the 0.5.0 milestone May 29, 2023
deeplow added a commit that referenced this issue Jun 6, 2023
@deeplow
Add change docs button to settings window
f7fa54f 
Implements the GUI logic necessary to change the selected document. When
"Change Selection" is clicked, it opens a File Dialog on the directory
of the previously selected files and highlights them. This gives the
user a chance to see which ones they had selected.

Fixes #428
deeplow added a commit that referenced this issue Jun 8, 2023
@deeplow
Add change docs button to settings window
7fc97f8 
Implements the GUI logic necessary to change the selected document. When
"Change Selection" is clicked, it opens a File Dialog on the directory
of the previously selected files (if any)

Fixes #428
@deeplow deeplow mentioned this issue Jun 8, 2023
Merged
@deeplow deeplow self-assigned this Jun 12, 2023
deeplow added a commit that referenced this issue Jun 12, 2023
@deeplow
Add unit test to document change button
f05cb1c 
Fixes #428
deeplow added a commit that referenced this issue Jul 18, 2023
@deeplow
Add change docs button to settings window
f1351e9 
Implements the GUI logic necessary to change the selected document. When
"Change Selection" is clicked, it opens a File Dialog on the directory
of the previously selected files (if any)

Fixes #428
deeplow added a commit that referenced this issue Jul 18, 2023
@deeplow
Add unit test to document change button
ba6610a 
Fixes #428
deeplow added a commit that referenced this issue Jul 25, 2023
@deeplow
Add unit test to document change button
9ca27fd 
Fixes #428
@apyrgio apyrgio modified the milestones: 0.5.0, 0.4.2 Aug 23, 2023
@deeplow deeplow mentioned this issue Sep 21, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deeplow deeplow

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.4.2
Development

Successfully merging a pull request may close this issue.

Add "change document selection" button freedomofpress/dangerzone
3 participants
@eloquence @apyrgio @deeplow