Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support CJK characters #468

Closed
deeplow opened this issue Jul 6, 2023 · 4 comments · Fixed by #460
Closed

Support CJK characters #468

deeplow opened this issue Jul 6, 2023 · 4 comments · Fixed by #460

Comments

@deeplow
Copy link
Contributor

deeplow commented Jul 6, 2023

We need to add CJK fonts for support Chinese, Japanese, and Korean languages. We can use for example the package font-noto-cjk-extra.

Before After
aaa aaabbb
@OctopusET
Copy link
Contributor

#460 (comment)
Like I commented here, there's some characters still not able to render. But only some very old articles would be the cases.

I think some day fonts should be added manually (and safely).

@OctopusET
Copy link
Contributor

I have to test but font-noto-cjk-extra might be not necessary for just showing characters. Some fonts like 'bold' might be render different, but if you think it would increase image size a lot font-noto-cjk would be enough

@OctopusET
Copy link
Contributor

I tested with this file.
This file contains the following fonts: "Noto Sans CJK KR *", "IBM Plex Sans KR *", "Noto Serif CJK KR *".

Original font-noto-cjk font-noto-cjk-extra
Original image font-noto-cjk image font-noto-cjk-extra image

I think font-noto-cjk would be sufficient. Although font-noto-cjk-extra can render much more fonts, but that's because those glyph (e.g. Noto Sans CJK Light) are also the noto fonts. For example, even IBM Plex Sans uses other glyph like 'IBM Plex Sans light' that Noto fonts can't render.

@deeplow
Copy link
Contributor Author

deeplow commented Jul 10, 2023

Thanks for investigating. Looks like font-noto-cjk will have to cut it for now. font-noto-cjk-extra would add an extra 200MB of downloaded packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants