Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

container-pip-dependencies.txt is getting packaged #739

Closed
deeplow opened this issue Mar 4, 2024 · 0 comments · Fixed by #740
Closed

container-pip-dependencies.txt is getting packaged #739

deeplow opened this issue Mar 4, 2024 · 0 comments · Fixed by #740
Labels
bug Something isn't working

Comments

@deeplow
Copy link
Contributor

deeplow commented Mar 4, 2024

Both v0.5.1 and v0.6.0 were bundling an uneeded file: Container-pip-dependenicies.txt.

@deeplow deeplow added the bug Something isn't working label Mar 4, 2024
@deeplow deeplow changed the title container-pip-dependenicies.txt is getting packaged container-pip-dependencies.txt is getting packaged Mar 4, 2024
deeplow added a commit that referenced this issue Mar 4, 2024
The file container-pip-dependencies.txt was being left a directory when
building the docker image. This meant that it was being packaged when it
wasn't supposed to.

To avoid this, we remove file with the help from a context manager.

The change is minimal and the biggest part of the diff are indentation
changes.

Fixes #739
deeplow added a commit that referenced this issue Mar 4, 2024
The file container-pip-dependencies.txt was being left a directory when
building the docker image. This meant that it was being packaged when it
wasn't supposed to.

To avoid this, we remove file with the help from a context manager.

The change is minimal and the biggest part of the diff are indentation
changes.

Fixes #739
@deeplow deeplow closed this as completed in 297feab Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant