Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container: fix issues pdftoppm-related (timeout & errors) #338

Merged
merged 2 commits into from
Feb 21, 2023

Conversation

deeplow
Copy link
Contributor

@deeplow deeplow commented Feb 13, 2023

After running the documents over a large test set some issues related to pdftoppm came to light. This provides fixes to some of those issues.

@deeplow deeplow changed the title Polish some details in container (timeout & errors) Container: fix issues pdftoppm-related (timeout & errors) Feb 13, 2023
@deeplow deeplow requested a review from apyrgio February 13, 2023 14:34
@deeplow deeplow added this to the 0.4.1 milestone Feb 13, 2023
Copy link
Contributor

@apyrgio apyrgio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor, but in 0909a59, we should change "to have document" -> "to have a document".

container/Dockerfile Outdated Show resolved Hide resolved
container/dangerzone.py Outdated Show resolved Hide resolved
Copy link
Contributor

@apyrgio apyrgio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw the updates and they look good to me. Feel free to merge, but make sure to drop the 803cbbe commit, as it will conflict with main.

Some documents were reporting the following error when running them
over pdftoppm:

    Syntax Error: Missing language pack for 'Adobe-Japan1' mapping

This did not necessarily make the document fail but it could be
that some fonts were not properly rendered due to the missing package.
@deeplow deeplow force-pushed the 2023-02-container-polish branch 2 times, most recently from 4313626 to f46aa47 Compare February 21, 2023 19:04
pdftoppm raises Syntax issues and Errors on a variety of documents.
But it still produces usable results despite the failures. From the
user's perspective it's best to have a document even if imperfect than
having none at all. For this reason, we ignore non-relevant output.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants