Add securedrop-workstation-config package to template #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Metapackage to install packages and configuration for the base template use for securedrop-workstation
Resolves template build error at `make template` phase where qubes-vm-dependencies has unmet dependencies qubes-gui-agent and breaks apt packages during the rootimg build.
conorsch
approved these changes
Oct 17, 2018
There was a problem hiding this comment.
LGTM, merging to include in automated build evaluation over in https://github.com/freedomofpress/securedrop-workstation/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Metapackage to install packages and configuration for the base template
use for securedrop-workstation. This package can be found in the https://github.com/freedomofpress/securedrop-debian-packaging repo.
Testing instructions (we could definitely improve the dev/testing story by adding another makefile target):
securedrop-workstation, run make template (you can cancel once the image starts building, the purpose is just to download the sources and bootstrap the dev env)*Apply changes in builder/qubes-builder/qubes-src/template-securedrop-workstation/: checkout this branch and
cp securedrop-workstation.conf ../builder.confqvm-prefs securedrop-workstation kernel ''qvm-prefs securedrop-workstation virt_mode hvmsecuredrop-workstation-configandsecuredrop-workstation-grsec