Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuilds client for template-consolidation #69

Merged
merged 1 commit into from
Oct 22, 2020

Conversation

conorsch
Copy link
Contributor

Status

Ready for review

Description of changes

Removes mimetypes from the securedrop-client package, given that they're now provided in
securedrop-workstation-config. See corresponding changes in:

Checklist

No build logs because specific to template consolidation (freedomofpress/securedrop-workstation#471). Visual review is sufficient

Removes mimetypes, given that they're now provided in
`securedrop-workstation-config`. See corresponding changes in:

  * freedomofpress/securedrop-client#1160
  * freedomofpress/securedrop-builder#198
Copy link
Contributor

@emkll emkll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, after comparing with local build

@emkll emkll merged commit d354fac into main Oct 22, 2020
@emkll emkll deleted the rebuild-client-for-template-consolidation branch October 22, 2020 13:43
@emkll emkll restored the rebuild-client-for-template-consolidation branch October 22, 2020 13:43
@emkll emkll deleted the rebuild-client-for-template-consolidation branch October 22, 2020 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants