Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PyYAML to 5.4.1 #219

Closed
emkll opened this issue Mar 2, 2021 · 2 comments · Fixed by freedomofpress/securedrop-proxy#82
Closed

Update PyYAML to 5.4.1 #219

emkll opened this issue Mar 2, 2021 · 2 comments · Fixed by freedomofpress/securedrop-proxy#82
Projects
SecureDrop Team Board

Comments

@emkll
Copy link
Contributor

emkll commented Mar 2, 2021 •
edited

CI is currently failing in proxy, client and sdk repositories due to CVE-2020-14343. associated to the version of PyYAML used:

It looks like in the case of Client and SDK, PyYAML is only a dev dependency: only the proxy uses PyYAML in a production context.
@kushaldas has already done a diff review in https://github.com/freedomofpress/securedrop-debian-packaging/wiki/PyYAML-5.3.1-to-5.4.1
@emkll emkll added this to Near Term - SD Workstation in SecureDrop Team Board Mar 2, 2021
@sssoleileraaa
Copy link
Contributor

to avoid having to monitor yet another slack channel, we could add a nightly to the repos to show safety failures in github

emkll added a commit to freedomofpress/securedrop-client that referenced this issue Mar 2, 2021
@emkll
Add CI nightly run
68616b4 
Initially suggested by @creviera in
freedomofpress/securedrop-builder#219 (comment),
let's add a nightly CI run to show CI failures in GitHub.
This was referenced Mar 2, 2021
Merged
Merged
Merged
@emkll
Copy link
Contributor Author

emkll commented Mar 2, 2021

to avoid having to monitor yet another slack channel, we could add a nightly to the repos to show safety failures in github

Great idea. I've added a commit for both client and proxy to add nightly CI runs in freedomofpress/securedrop-client#1222 and freedomofpress/securedrop-proxy#82 respectively. (SDK already has nightly builds, see https://github.com/freedomofpress/securedrop-sdk/blob/15bc20af8113148db173add854c7844fad65078e/.circleci/config.yml#L82-L91)

@emkll emkll mentioned this issue Mar 16, 2021
Merged
3 tasks
SecureDrop Team Board automation moved this from Near Term - SD Workstation to Done Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
No open projects
SecureDrop Team Board
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updates PyYAML to 5.4.1 freedomofpress/securedrop-proxy
2 participants
@sssoleileraaa @emkll