Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

had to install python-setuptools #232

Closed
sssoleileraaa opened this issue Mar 17, 2021 · 1 comment · Fixed by #237
Closed

had to install python-setuptools #232

sssoleileraaa opened this issue Mar 17, 2021 · 1 comment · Fixed by #237
Assignees

Comments

@sssoleileraaa
Copy link
Contributor

sssoleileraaa commented Mar 17, 2021

Description

Recently when building debs, I had to install python-setuptools in order for this command to work:

PKG_VERSION=0.4.1 make securedrop-client

It looks like we install python3-setuptools via make build-deps but it appears the script to build debian packages is run using system python, which is why I had to install the python2 version.

@kushaldas kushaldas self-assigned this Mar 30, 2021
@kushaldas
Copy link
Contributor

I can reproduce this:

Cloning into '/tmp/securedrop-client'...
remote: Enumerating objects: 167, done.
remote: Counting objects: 100% (167/167), done.
remote: Compressing objects: 100% (124/124), done.
remote: Total 9932 (delta 73), reused 93 (delta 39), pack-reused 9765
Receiving objects: 100% (9932/9932), 7.61 MiB | 9.81 MiB/s, done.
Resolving deltas: 100% (7313/7313), done.
Note: checking out '0.4.1'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b <new-branch-name>

HEAD is now at 94efe51 Merge pull request #1226 from freedomofpress/check-paths
Traceback (most recent call last):
  File "setup.py", line 3, in <module>
    import setuptools
ImportError: No module named setuptools
make: *** [Makefile:9: securedrop-client] Error 1

kushaldas added a commit that referenced this issue Mar 30, 2021
We are now using the Python3 setuptools package
to create the source tarballs.
emkll added a commit that referenced this issue Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants