-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build wheels with build #240
Conversation
That's right, we expect the wheels containing .so files to change slightly. It looks like the path that
Right now CI is failing on these changes, because of the mismatch between the reqs files on the various component repos. By way of example, I've pushed a "TEMPORARY" commit to securedrop-proxy freedomofpress/securedrop-proxy#85 (comment) which uses this branch, and CI has gone green over there. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test Plan
- Check out use new reproducible wheels from packaging with build securedrop-client#1238 for the client and use new reproducible wheel from packaging with build securedrop-proxy#85 for the proxy and this PR branch
- Run through steps listed here: Regenerate wheels and
build-requirements.txt
files for projects #239 - Confirm that there are no new requirements files generated for client, proxy, and log
- Build the debian packages to confirm we are prepared to successfully release in the future without error
Next steps
After we merge those two PRs, we can push more changes to the CI steps in this PR so that it becomes green. We can then merge this PR.
I've merged the two component PRs consuming the newly rebuilt wheels:
Then re-ran CI here, and it's already entirely green.
Not necessary! CI is already passing. Looks like recent changes in 18770bd have accommodated. Let's keep a close eye on nightly builds, so those job configs are slightly different, and patch as necessary. The most problematic aspect of this workflow is that I had to override CI in the component repos in order to merge. That's not ideal, but since the CI configs in the various repos reference each other's main branches, it's the best we can do. Let's discuss marking the build jobs as optional, so maintainers can override as they see fit. |
Description
Resolves #239
You can see there are 4 changes here:
build
(our new packaging tool) versuspip
. @conorsch plz verify or correct me if I am mistaken.build-requirements.txt
file is created insecuredrop-client
when it already exists inrequirements/build-requirements.txt
.Test Plan
build-requirements.txt
files for projects #239