-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update apt LFS repo names #413
Conversation
@maeve-fpf - this looks good to me, and once the repo names are changed, we should see ci go green |
The renames are now done; let's retry CI! |
Looks like all the bookworm builds are failing - checking with @legoktm since this looks unrelated... |
I thiiiiink the failures are caused by https://setuptools.pypa.io/en/latest/history.html#id23 - in any case, I think it's safe to ignore them since it's just bookworm and I'll file a follow-up task. |
(Yeah, per https://github.com/freedomofpress/securedrop-apt-test/commits/main bookworm nightlies have been broken since the 9th, so not a new issue) |
Okay then, I will also link to your comment in #400 so we can merge past these errors there as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@@ -23,8 +23,8 @@ from typing import Tuple | |||
from debian import debfile | |||
|
|||
BUILDER = Path(__name__).absolute().parent | |||
DEV_LFS = BUILDER.parent / 'securedrop-dev-packages-lfs' | |||
PROD_LFS = BUILDER.parent / 'securedrop-debian-packages-lfs' | |||
DEV_LFS = BUILDER.parent / 'securedrop-apt-test' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Presumably this should be TEST_LFS
now, as well as all the other variables named "dev". I'll submit a follow-up.
For #304, rename references to the renamed repos in CircleCI configs and scripts. See also #400, which makes more updates to documentation -- the change here will be removed by one of those commits, but I left it in for clarity.
We will proceed with the renaming on the GitHub end later today (2023-02-14), but old clones will continue to work.