Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update apt LFS repo names #413

Merged
merged 1 commit into from
Feb 14, 2023
Merged

Update apt LFS repo names #413

merged 1 commit into from
Feb 14, 2023

Conversation

maeve-fpf
Copy link
Contributor

For #304, rename references to the renamed repos in CircleCI configs and scripts. See also #400, which makes more updates to documentation -- the change here will be removed by one of those commits, but I left it in for clarity.

We will proceed with the renaming on the GitHub end later today (2023-02-14), but old clones will continue to work.

@sssoleileraaa
Copy link
Contributor

@maeve-fpf - this looks good to me, and once the repo names are changed, we should see ci go green

@maeve-fpf
Copy link
Contributor Author

The renames are now done; let's retry CI!

@sssoleileraaa
Copy link
Contributor

Looks like all the bookworm builds are failing - checking with @legoktm since this looks unrelated...

@legoktm
Copy link
Member

legoktm commented Feb 14, 2023

I thiiiiink the failures are caused by https://setuptools.pypa.io/en/latest/history.html#id23 - in any case, I think it's safe to ignore them since it's just bookworm and I'll file a follow-up task.

@legoktm
Copy link
Member

legoktm commented Feb 14, 2023

(Yeah, per https://github.com/freedomofpress/securedrop-apt-test/commits/main bookworm nightlies have been broken since the 9th, so not a new issue)

@sssoleileraaa
Copy link
Contributor

Okay then, I will also link to your comment in #400 so we can merge past these errors there as well.

Copy link
Contributor

@sssoleileraaa sssoleileraaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sssoleileraaa sssoleileraaa merged commit 90c44f3 into main Feb 14, 2023
@sssoleileraaa sssoleileraaa deleted the update-repo-name-pt2 branch February 14, 2023 21:46
@@ -23,8 +23,8 @@ from typing import Tuple
from debian import debfile

BUILDER = Path(__name__).absolute().parent
DEV_LFS = BUILDER.parent / 'securedrop-dev-packages-lfs'
PROD_LFS = BUILDER.parent / 'securedrop-debian-packages-lfs'
DEV_LFS = BUILDER.parent / 'securedrop-apt-test'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presumably this should be TEST_LFS now, as well as all the other variables named "dev". I'll submit a follow-up.

@sssoleileraaa sssoleileraaa mentioned this pull request Feb 22, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants