chore: remove unused Config.is_valid(); just test Config.load()

thread: https://github.com/freedomofpress/securedrop-client/pull/1883/files#r1508506960
freedomofpress · Mar 7, 2024 · 2e0ae4c · 2e0ae4c
1 parent 3fbed5f
commit 2e0ae4c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 8 deletions.
diff --git a/client/securedrop_client/config.py b/client/securedrop_client/config.py
@@ -42,7 +42,3 @@ def load(self) -> "Config":
             setattr(config, store, value)
 
         return config
-
-    @property
-    def is_valid(self) -> bool:
-        return self.journalist_key_fingerprint is not None
diff --git a/client/tests/test_config.py b/client/tests/test_config.py
@@ -4,12 +4,12 @@
 from securedrop_client.config import Config
 
 
-@patch.dict(os.environ, {"SD_SUBMISSION_KEY_FPR": ""})
-def test_missing_journalist_key_fpr():
+@patch.dict(os.environ, {"SD_SUBMISSION_KEY_FPR": "foobar"})
+def test_config():
     """
     If a key is missing, the config can still be loaded, but is "invalid".
     """
     config = Config.load()
 
-    assert config.journalist_key_fingerprint is None
-    assert config.is_valid is False
+    assert config.journalist_key_fingerprint == "foobar"
+    assert config.gpg_domain is None