Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate move to PySide2 from PyQt5 #1194

Open
1 of 2 tasks
kushaldas opened this issue Nov 27, 2020 · 5 comments
Open
1 of 2 tasks

Investigate move to PySide2 from PyQt5 #1194

kushaldas opened this issue Nov 27, 2020 · 5 comments

Comments

@kushaldas
Copy link
Contributor

kushaldas commented Nov 27, 2020

Motivation

PySide2 is the official Python binding for Qt from Qt company. They provide official support for the same. It also gets better updates. That is the primary reason for me to suggest the same.

Tasks

Two spikes should be conducted to investigate the feasibility of this task (~4h timeboxes for each), this can be done in either order:

  • Ensure that PySide2 wheel can be built from source (can we use the existing logic in the packaging repository?):
    add more developer docs #1089 (comment)

  • Update requirements/dev-requirements.txt to use PySide2, replacing the imports and ensuring the client is working as expected.

@emkll emkll changed the title Try to build PySide2 from source Investigate move to PySide2 from PyQt5 Nov 30, 2020
@emkll emkll added this to Near Term - SD Workstation in SecureDrop Team Board Nov 30, 2020
@kushaldas
Copy link
Contributor Author

PySide2 is the official Python binding for Qt from Qt company. They provide official support for the same. It also gets better updates. That is the primary reason for me to suggest the same.

@emkll
Copy link
Contributor

emkll commented Dec 16, 2020

@kushaldas has investigated the first step (wheel build) in #1089 (comment) . It will require a special case to handle the build logic for these wheels, since sources tarballs for pyside are not available on PyPI and requires additional dependencies and configuration .

@eloquence eloquence moved this from Near Term - SD Workstation to SecureDrop Sprint #65 - 1/21-2/3 in SecureDrop Team Board Jan 21, 2021
@eloquence
Copy link
Member

(This is on the 1/21-2/3 sprint for additional investigation & discussion, as time permits given competing 1.7.0/Focal priorities.)

@eloquence eloquence moved this from SecureDrop Sprint #66 - 2/3-2/17 to Near Term - SD Workstation in SecureDrop Team Board Feb 3, 2021
@eloquence eloquence moved this from Near Term - SD Workstation to 1.8.1 Release Period (Kanban Mode) in SecureDrop Team Board Apr 12, 2021
@eloquence
Copy link
Member

@creviera has committed to time-boxed work (4 hours) to further investigate if she can successfully build Qt and pyside2 wheels, following the process described by Kushal in #1089 (comment)

To recap, the motivation here is twofold, as I understand it:

  • being able to reliably build Qt and its Python bindings to aid in debugging investigations
  • migrating to the official bindings, which may have maintainability benefits in future.

As we continue this investigation, we'll monitor whether we're indeed able to realize both of those benefits.

@eloquence eloquence moved this from To Do (Kanban Period) to Near Term - SD Workstation in SecureDrop Team Board May 5, 2021
@eloquence eloquence moved this from Near Term - SD Workstation to Next sprint candidates in SecureDrop Team Board Dec 1, 2021
@eloquence eloquence moved this from Next sprint candidates to To Do (Kanban period) in SecureDrop Team Board Dec 1, 2021
@sssoleileraaa sssoleileraaa moved this from To Do (Kanban period) to Near Term - SD Workstation in SecureDrop Team Board Dec 1, 2021
@sssoleileraaa sssoleileraaa moved this from Near Term - SD Workstation to To Do (Kanban period) in SecureDrop Team Board Dec 1, 2021
@sssoleileraaa
Copy link
Contributor

sssoleileraaa commented Dec 1, 2021

I'll be coming back to this issue within the next couple of weeks to see if we're ready to get started on a migration plan from pyqt to pyside.

--

Update: we decided to prioritize other issues and removed this from the near term

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants