Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reply pending state #350

Closed
sssoleileraaa opened this issue May 1, 2019 · 2 comments · Fixed by #578
Closed

Reply pending state #350

sssoleileraaa opened this issue May 1, 2019 · 2 comments · Fixed by #578
Assignees
@redshiftzero

Comments

@sssoleileraaa
Copy link
Contributor

sssoleileraaa commented May 1, 2019 •
edited

Description

Should fix: #294

Show the reply as grayed out until SendReplyJob is processed successfully. Make sure replies are not lost. This requires altering the replies database table so that we can store know when a reply is queued to be sent.

See zeplin for grayed out text visual. The animation icon on the left-hand side of the reply widget is out of scope for this issue.
This was referenced May 1, 2019
Open
Closed
@eloquence eloquence mentioned this issue May 7, 2019
Closed
@sssoleileraaa
Copy link
Contributor Author

sssoleileraaa commented May 9, 2019 •
edited

Note: if the reply fails show the bar at the bottom as red, as seen here in the Zeplin Screen:
zeplin-screen-red-bar

Resolves #365 when this is done.

@eloquence eloquence mentioned this issue Jun 11, 2019
Closed
4 tasks
@sssoleileraaa
Copy link
Contributor Author

Update: The red bar was added here: #464

@sssoleileraaa sssoleileraaa changed the title Reply sending state in ConversationView Reply pending state Aug 13, 2019
@eloquence eloquence mentioned this issue Aug 20, 2019
Open
@eloquence eloquence added this to Near Term Backlog in SecureDrop Team Board Sep 4, 2019
@redshiftzero redshiftzero mentioned this issue Oct 21, 2019
Merged
3 tasks
@redshiftzero redshiftzero self-assigned this Oct 21, 2019
@redshiftzero redshiftzero moved this from Near Term - SD Workstation to In Development in SecureDrop Team Board Oct 22, 2019
@redshiftzero redshiftzero removed this from In Development in SecureDrop Team Board Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@redshiftzero redshiftzero

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

app: add pending reply status, persist replies in the database freedomofpress/securedrop-client
2 participants
@sssoleileraaa @redshiftzero