Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app: add color bar on bottom of message bubbles, set standard message spacing #464

Merged
merged 3 commits into from
Jul 10, 2019

Conversation

redshiftzero
Copy link
Contributor

@redshiftzero redshiftzero commented Jul 5, 2019

Description

Sets standard message spacing and message width as speced in zeplin. Closes #466

Adds a tiny 5px color bar (as defined in zeplin) to the bottom of each message:

Screen Shot 2019-07-05 at 3 04 25 PM

and the reply will turn coral on reply failure:

Screen Shot 2019-07-05 at 3 06 03 PM

Closes #365 (will file followups for the other reply failure tasks)

Test plan

Test the GUI changes seem reasonable, and also verify the reply failure case updates the UI (I put in an abort(500, 'TEST') here to test)

Also follow STR from #466 in order to test that the message spacing is now uniform 28px and cannot push down the color bar.

Checklist

If these changes modify code paths involving cryptography, the opening of files in VMs, network (via the RPC service) traffic, or fine tuning of the graphical user interface, Qubes testing is required. Please check as applicable:

  • I have tested these changes in Qubes
  • I do not have a Qubes OS workstation (the reviewer will need to test these changes in Qubes)
  • GUI changes only, no qubes testing needed

(and have color bar turn coral on reply failure)
@redshiftzero redshiftzero changed the title app: add color bar on bottom of message bubbles [wip] app: add color bar on bottom of message bubbles Jul 5, 2019
also implemented some minor styling as speced in
zeplin, e.g. all the message bubbles are 556px in width
@redshiftzero redshiftzero changed the title [wip] app: add color bar on bottom of message bubbles app: add color bar on bottom of message bubbles, set standard message spacing Jul 8, 2019
@redshiftzero
Copy link
Contributor Author

This should be ready for review, and it also addresses #466 - though be aware of the other outstanding bug on master #467 which will impact testing (short version: restart the app if you submit a new test message on an existing source). Since #466 is addressed here this is fine to merge since it is to do how the conversation view is drawn, the other outstanding bugs are to do with when the conversation view is drawn.

Copy link
Contributor

@sssoleileraaa sssoleileraaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gorg!

@sssoleileraaa sssoleileraaa merged commit fa9e636 into master Jul 10, 2019
@sssoleileraaa sssoleileraaa deleted the message-bubble-color-bar branch July 10, 2019 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spacing between messages not consistent Clearly indicate that a reply failed to send
2 participants