Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replies are lost after switching sources #393

Closed
sssoleileraaa opened this issue May 30, 2019 · 0 comments · Fixed by #431
Closed

Replies are lost after switching sources #393

sssoleileraaa opened this issue May 30, 2019 · 0 comments · Fixed by #431
Assignees
Labels
bug Something isn't working

Comments

@sssoleileraaa
Copy link
Contributor

Description

Lost replies when clicking from one source to another.

STR

  1. Type into the reply box
  2. Before sending, click a different source
  3. Click back to the original source that you were replying to, and see the reply is lost

This has to do with the way we create new SourceConversationWrappers whenever a new source is selected.

Proposal

2 parts:

  1. When we recreate our list of sources every time there's a sync, also create the corresponding conversation views associated with those sources, instead of waiting until a source is selected. By default, hide these conversations.

  2. When a source is selected, show the corresponding conversation.

This will make it so the text in the replybox gets hidden instead of deleted.

@sssoleileraaa sssoleileraaa added the bug Something isn't working label May 30, 2019
@eloquence eloquence added this to Near Term Backlog in SecureDrop Team Board May 30, 2019
@eloquence eloquence changed the title Lost reply Replies are lost after switching sources May 30, 2019
@eloquence eloquence moved this from Near Term Backlog to Nominated for next sprint (6/12-6/26) in SecureDrop Team Board Jun 7, 2019
@eloquence eloquence moved this from Current sprint nominations (in progress) to Current Sprint - 6/12-6/26 in SecureDrop Team Board Jun 12, 2019
@redshiftzero redshiftzero moved this from Current Sprint - 6/12-6/26 to In Development in SecureDrop Team Board Jun 17, 2019
@redshiftzero redshiftzero moved this from In Development to Current Sprint - 6/12-6/26 in SecureDrop Team Board Jun 18, 2019
@redshiftzero redshiftzero self-assigned this Jun 18, 2019
@redshiftzero redshiftzero moved this from Current Sprint - 6/12-6/26 to In Development in SecureDrop Team Board Jun 18, 2019
@redshiftzero redshiftzero removed this from In Development in SecureDrop Team Board Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants