Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #956 Adds flaky for functinoal tests #1001

Merged
merged 1 commit into from Mar 25, 2020
Merged

Conversation

kushaldas
Copy link
Contributor

Description

Fixes #956

Now we are using pytest-flaky for all the functional tests.

Test Plan

  • Verify the change by reading the diff
  • CI is green
  • make test-functional locally runs fine

Checklist

If these changes modify code paths involving cryptography, the opening of files in VMs or network (via the RPC service) traffic, Qubes testing in the staging environment is required. For fine tuning of the graphical user interface, testing in any environment in Qubes is required. Please check as applicable:

  • I have tested these changes in the appropriate Qubes environment
  • I do not have an appropriate Qubes OS workstation set up (the reviewer will need to test these changes)
  • These changes should not need testing in Qubes

If these changes add or remove files other than client code, packaging logic (e.g., the AppArmor profile) may need to be updated. Please check as applicable:

  • I have submitted a separate PR to the packaging repo
  • No update to the packaging logic (e.g., AppArmor profile) is required for these changes
  • I don't know and would appreciate guidance

@redshiftzero redshiftzero added this to Under Review in SecureDrop Team Board Mar 25, 2020
@redshiftzero redshiftzero moved this from Under Review to Ready for Review in SecureDrop Team Board Mar 25, 2020
Now we are using pytest-flaky for all the functional tests.
@redshiftzero redshiftzero merged commit bd94b7c into master Mar 25, 2020
SecureDrop Team Board automation moved this from Ready for Review to Done Mar 25, 2020
@redshiftzero redshiftzero deleted the oh_my_flaky branch March 25, 2020 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Use pytest-flaky to retry fragile functional tests.
2 participants