Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove leading and trailing whitespace #1058

Merged
merged 2 commits into from Apr 15, 2020
Merged

remove leading and trailing whitespace #1058

merged 2 commits into from Apr 15, 2020

Conversation

sssoleileraaa
Copy link
Contributor

Description

Resolves #1030

Test Plan

  1. Send messages from the source interface with leading and trailing spaces and newlines and see that they are removed in the snippet and message bubbles

@sssoleileraaa sssoleileraaa added this to Ready for Review in SecureDrop Team Board Apr 10, 2020
kushaldas
kushaldas approved these changes Apr 15, 2020
View reviewed changes
Copy link
Contributor

@kushaldas kushaldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well. Approved.

@kushaldas kushaldas merged commit 4c4bd4e into master Apr 15, 2020
SecureDrop Team Board automation moved this from Ready for Review to Done Apr 15, 2020
@kushaldas kushaldas deleted the fix-1030 branch April 15, 2020 08:52
@redshiftzero redshiftzero mentioned this pull request May 7, 2020
Merged
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kushaldas kushaldas kushaldas approved these changes

@redshiftzero redshiftzero Awaiting requested review from redshiftzero

Assignees
No one assigned
Labels
None yet
Projects
No open projects
SecureDrop Team Board
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider trimming leading and trailing whitespace from messages
2 participants
@sssoleileraaa @kushaldas