Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only show a preview if its the *last* message/file/reply for a source #1131

Merged
merged 1 commit into from
Aug 4, 2020
Merged

Only show a preview if its the *last* message/file/reply for a source #1131

merged 1 commit into from
Aug 4, 2020

Conversation

sssoleileraaa
Copy link
Contributor

@sssoleileraaa sssoleileraaa commented Jul 29, 2020 •
edited

Description

Fixes #1121

Test Plan

  1. Run through STR in issue that this fixes and verify that expected state is what happens now
  2. Send a new message from the SI and see that it gets displayed in the preview

Checklist

  • I have tested these changes in the appropriate Qubes environment
  • No update to the AppArmor profile is required for these changes
  • No database schema changes are needed

Once tests are written, I will move this out of a draft PR state

@sssoleileraaa sssoleileraaa changed the title save Show preview snippet of last reply as previous messages are still decrypting Jul 29, 2020
@sssoleileraaa sssoleileraaa added this to In Development in SecureDrop Team Board Jul 29, 2020
@sssoleileraaa sssoleileraaa force-pushed the show-correct-preview-as-msgs-decrypt branch 2 times, most recently from 2b6c0b2 to 968b61b Compare July 29, 2020 19:31
@sssoleileraaa sssoleileraaa marked this pull request as ready for review July 29, 2020 22:05
@eloquence eloquence moved this from In Development to Ready for Review in SecureDrop Team Board Jul 29, 2020
@sssoleileraaa sssoleileraaa changed the title Show preview snippet of last reply as previous messages are still decrypting Make sure we only show a preview if its the *last* message/file/reply for a source Jul 30, 2020
@sssoleileraaa sssoleileraaa changed the title Make sure we only show a preview if its the *last* message/file/reply for a source Only show a preview if its the *last* message/file/reply for a source Jul 30, 2020
@sssoleileraaa sssoleileraaa force-pushed the show-correct-preview-as-msgs-decrypt branch from 968b61b to d272163 Compare July 30, 2020 18:53
@kushaldas kushaldas force-pushed the show-correct-preview-as-msgs-decrypt branch from d272163 to 89079e8 Compare August 4, 2020 10:33
kushaldas
kushaldas approved these changes Aug 4, 2020
View reviewed changes
Copy link
Contributor

@kushaldas kushaldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as tested with STR. Approved.

@kushaldas kushaldas merged commit 291350c into main Aug 4, 2020
SecureDrop Team Board automation moved this from Ready for Review to Done Aug 4, 2020
@kushaldas kushaldas deleted the show-correct-preview-as-msgs-decrypt branch August 4, 2020 11:02
@eloquence eloquence mentioned this pull request Oct 23, 2020
Closed
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kushaldas kushaldas kushaldas approved these changes

@redshiftzero redshiftzero Awaiting requested review from redshiftzero

Assignees
No one assigned
Labels
None yet
Projects
No open projects
SecureDrop Team Board
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Preview not showing last reply when decrypting previous messages
2 participants
@sssoleileraaa @kushaldas