update requirements: securedrop-sdk 0.2.0 #1172
Conversation
|
After merging freedomofpress/securedrop-builder#204 and the new sdk wheels live on the pypi mirror https://pypi.securedrop.org/simple/securedrop-sdk/ which now unblocks work here. We should update https://github.com/freedomofpress/securedrop-client/blob/update-to-sdk-0.2.0/requirements/build-requirements.txt#L12 prior to merging to ensure the new version of the wheel is included in the builds. I just restarted CI after the pypi mirror was updated, there is what appears to be a valid test failure here. |
sssoleileraaa
force-pushed
the
update-to-sdk-0.2.0
branch
3 times, most recently
from
95c350d
to
be64d6e
Compare
sssoleileraaa
requested review from
kushaldas and
redshiftzero
as code owners
|
I would suggest deferring merge until we tag the next client release, just out of conservatism (we don't need the changes in the SDK yet for the release bundled as SDW 0.5.0). |
sssoleileraaa
force-pushed
the
update-to-sdk-0.2.0
branch
2 times, most recently
from
324a25d
to
1566588
Compare
|
since we'll want functional tests that test (1) we are getting seen data from the server, and (2) we are sending seen data to the server, i'll want to add that to this pr instead: #1165 that way i can do functional tests all at once utilizing the new |
sssoleileraaa
force-pushed
the
update-to-sdk-0.2.0
branch
from
1566588
to
fd798ce
Compare
I change my mind. This repo is not busy enough to force this check. |
sssoleileraaa
moved this from In Development
to Ready for Review
in SecureDrop Team Board
The strict status check to enforce that branches are always up-to-date with the base branch before merge has been removed. Feels like a heavy weight has been lifted! |
sssoleileraaa
force-pushed
the
update-to-sdk-0.2.0
branch
from
fd798ce
to
cc60d73
Compare
| @@ -9,7 +9,7 @@ pathlib2==2.3.2 --hash=sha256:460e67b14d0574b0529a0017b1eb05d10d9722681e303fec70 | |||
| python-dateutil==2.7.5 --hash=sha256:f6eb9c17acd5a6954e1a5f2f999a41de3e7e25b6bc41baf6344bd053ec25ceeb | |||
| python-editor==1.0.3 --hash=sha256:e47dcec4ea883853b8196fbd425b875d7ec791d4ede2e20cfc70b9a25365c65b | |||
| requests==2.22.0 --hash=sha256:e3711bd465fd013abe428a8dade2938b578f05d2b06b0ae83daa98869c4548e8 | |||
| securedrop-sdk==0.1.1 --hash=sha256:a631495acd741ab568410287879c5a3af3ccd38e00a2f3a127cc6b27cba99392 | |||
| securedrop-sdk==0.2.0 --hash=sha256:dd0231e1b873197373a7e84e3610370634eead601223551153eca7cdd166e7d5 | |||
| securedrop-sdk==0.1.1 \ | ||
| --hash=sha256:138ce7a717db519c3c8d19b9475d7660fb7095d7608e8802723e682a7415e677 \ | ||
| securedrop-sdk==0.2.0 \ | ||
| --hash=sha256:c4a343077e8c0a38914e17f6369b830f1e361f9d66699b20803c07b39472357f \ |
sssoleileraaa
force-pushed
the
update-to-sdk-0.2.0
branch
from
cc60d73
to
a4d7943
Compare
Description
Bumps SDK to version 0.2.0. Just opening this PR even though we're not ready to use the latest SDK yet since I needed to update the client requirements in order to build the latest SDK wheels here: freedomofpress/securedrop-builder#204 (due to our package build logic)