Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(backport) Fix journalist association bug in draftreplies #1188

Merged
merged 1 commit into from Nov 10, 2020

Conversation

emkll
Copy link
Contributor

@emkll emkll commented Nov 9, 2020

(cherry picked from commit 824e0a2)

Description

Fixes #1185, backport changes from #1184

Test Plan

  • CI is passing
  • Migration successful
  • Conflicts in backport have been successfully resolved

Checklist

If these changes modify code paths involving cryptography, the opening of files in VMs or network (via the RPC service) traffic, Qubes testing in the staging environment is required. For fine tuning of the graphical user interface, testing in any environment in Qubes is required. Please check as applicable:

  • I have tested these changes in the appropriate Qubes environment
  • I do not have an appropriate Qubes OS workstation set up (the reviewer will need to test these changes)
  • These changes should not need testing in Qubes

If these changes add or remove files other than client code, the AppArmor profile may need to be updated. Please check as applicable:

  • I have updated the AppArmor profile
  • No update to the AppArmor profile is required for these changes
  • I don't know and would appreciate guidance

If these changes modify the database schema, you should include a database migration. Please check as applicable:

  • I have written a migration and upgraded a test database based on main and confirmed that the migration applies cleanly
  • I have written a migration but have not upgraded a test database based on main and would like the reviewer to do so
  • I need help writing a database migration
  • No database schema changes are needed

@emkll emkll added this to Ready for Review in SecureDrop Team Board Nov 9, 2020
@emkll emkll moved this from Ready for Review to In Development in SecureDrop Team Board Nov 9, 2020
@emkll emkll moved this from In Development to Ready for Review in SecureDrop Team Board Nov 9, 2020
Copy link
Contributor

@sssoleileraaa sssoleileraaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • CI is passing
  • Migration successful
  • Conflicts in backport have been successfully resolved

@sssoleileraaa sssoleileraaa merged commit a90a6af into main Nov 10, 2020
SecureDrop Team Board automation moved this from Ready for Review to Done Nov 10, 2020
@sssoleileraaa sssoleileraaa deleted the port-1184-to-main branch November 10, 2020 17:41
@sssoleileraaa sssoleileraaa changed the title Fix journalist association bug in draftreplies (backport) Fix journalist association bug in draftreplies Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Client crashes if there are failed replies in local db from a previous run of the 0.2.1 client
2 participants