New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stretch background of left pane #1210
Conversation
ca5cea7
to
db6b765
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh interesting! great screenshots kushal - what you're seeing is also happening on the |
(Given current sprint priorities, moving to top of backlog for now.) |
Here's an update on my progress: Words: The remaining thing left to do is to fix this: The easiest thing might be to just edit the SVG so that the viewbox is taller (right now it's at 884px, and perhaps we just want to make it the largest size we plan on supporting for the client). But I think with two more custom widgets we can have the look we're going for here AND support an enormous client window (it's just a bit more complicated to do). :] |
Okay this is ready |
Signed-off-by: Allie Crevier <allie@freedom.press>
Functionally this looks good to me! The scaling behavior is nicer even on smaller screen sizes (logo is always visible), and in portrait mode, it resolves #1209 for me as advertised. BeforeAfter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
Fixes #1209
Checklist
If these changes modify code paths involving cryptography, the opening of files in VMs or network (via the RPC service) traffic, Qubes testing in the staging environment is required. For fine tuning of the graphical user interface, testing in any environment in Qubes is required. Please check as applicable:
If these changes add or remove files other than client code, the AppArmor profile may need to be updated. Please check as applicable:
If these changes modify the database schema, you should include a database migration. Please check as applicable:
main
and confirmed that the migration applies cleanlymain
and would like the reviewer to do so