Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete conversation files and records as soon as server confirms scheduled deletion #1432

Merged
merged 6 commits into from
Mar 14, 2022
Merged

Delete conversation files and records as soon as server confirms scheduled deletion #1432

merged 6 commits into from
Mar 14, 2022

Commits on Mar 8, 2022

  1. Add DeletedConversation table to db, add alembic migration

    @rocodes
    rocodes committed Mar 8, 2022
    Configuration menu
    Copy the full SHA
    5af5271 View commit details
    Browse the repository at this point in the history

  2. Check if source uuid is in DeletedConversation table before updating … 

    …source records. (Skip source for one sync).

Add local delete of files, messages, and replies for source by uuid. Add error-handling in case of race condition between sync-delete and local delete.
    @rocodes
    rocodes committed Mar 8, 2022
    Configuration menu
    Copy the full SHA
    3184054 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2022

  1. Fix existing tests, add new unit tests to test local delete.

    @rocodes
    rocodes committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    227a77b View commit details
    Browse the repository at this point in the history

  2. Check deletedconversation table for source uuid before adding

    @rocodes
    rocodes committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    1b68a9c View commit details
    Browse the repository at this point in the history

  3. Simplify how a reply is added from the replybox

    @rocodes
    Allie Crevier authored and rocodes committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    29cfdb7 View commit details
    Browse the repository at this point in the history

  4. Remove old way of checking deletion timestamp 

    Signed-off-by: Allie Crevier <allie@freedom.press>
    @rocodes
    Allie Crevier authored and rocodes committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    1862d7c View commit details
    Browse the repository at this point in the history