If user has manually unlocked USB drive, don't re-prompt for pasphrase #1462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support multiple valid ExportStatus values in _disk_test. Return an ExportStatus from preflight disk check and skip password prompt if export disk is already unlocked.
rocodes
commented
Apr 5, 2022
| # On the way to success | ||
| USB_CONNECTED = "USB_CONNECTED" | ||
| DISK_ENCRYPTED = "USB_ENCRYPTED" | ||
|
|
||
| # (Success) Drive is compatible and unlocked; do not prompt for passphrase | ||
| USB_ENCRYPTED_UNLOCKED = "USB_ENCRYPTED_UNLOCKED" | ||
|
|
There was a problem hiding this comment.
as mentioned in the PR, in the future we'll refine this to return multiple status codes (LUKS_UNLOCKED, VERACRYPT_UNLOCKED)
|
A couple tests are failing because the export checker is looking for QubesOS, and on CI we're returning |
|
I'm going to close this since it will be superseded by the refactor/wizard changes coming to sd-export. |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If a user has unlocked their Export device (i.e. via the commandline or by opening Nautilus in
sd-devicesand inputting the passphrase), recognize that the drive is unlocked and don't ask again for passphrase before exporting documents.Returns a status code from the disk checks run in
sd-export(This will also enable us to incorporate other response/status codes, for example to distinguish between LUKS and Veracrypt devices, in future).Note Changes must be tested with corresponding changes in
sd-exportand released together.Fixes #1734 (Together with corresponding sd-export PR)
Towards freedomofpress/securedrop-workstation#265
Test Plan
TK
Checklist
If these changes modify code paths involving cryptography, the opening of files in VMs or network (via the RPC service) traffic, Qubes testing in the staging environment is required. For fine tuning of the graphical user interface, testing in any environment in Qubes is required. Please check as applicable:
If these changes add or remove files other than client code, the AppArmor profile may need to be updated. Please check as applicable:
If these changes modify the database schema, you should include a database migration. Please check as applicable:
mainand confirmed that the migration applies cleanlymainand would like the reviewer to do so