Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor export service to accomodate polling printer and disk #1615

Closed
Show file tree
Hide file tree
Changes from 39 commits
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
c279e61
Refactor remove redundant suffix from action names
gonzalo-bulnes Oct 25, 2022
33cc56d
Refactor reorganize export module
gonzalo-bulnes Dec 4, 2022
0c185d2
Refactor use QSignalSpy to assert on signal emissions
gonzalo-bulnes Dec 4, 2022
989b94c
Refactor deprecate export.Export test file
gonzalo-bulnes Dec 5, 2022
ee41aa6
Refactor decorate static methods
gonzalo-bulnes Dec 5, 2022
ebb9e51
Rename export.Service API signals (backwards compatible)
gonzalo-bulnes Dec 4, 2022
ae7fbb4
Rename export.Service officially (backwards-compatible)
gonzalo-bulnes Dec 4, 2022
3869f7b
Refactor extract export CLI interface (part 1)
gonzalo-bulnes Dec 4, 2022
e8cfab2
Refactor extract export CLI interface (part 2)
gonzalo-bulnes Dec 6, 2022
86def51
Refactor remove unused export.Service alias
gonzalo-bulnes Dec 4, 2022
9c752e9
Refactor make export service a module instance
gonzalo-bulnes Dec 3, 2022
0d53e22
Add export.Printer
gonzalo-bulnes Dec 4, 2022
0130f43
Fix polling setup
gonzalo-bulnes Dec 6, 2022
073597f
Rename export.Service API signals (backwards compatible)
gonzalo-bulnes Dec 29, 2022
d5426ea
Refactor remove/rename references to preflight checks in export.Servi…
gonzalo-bulnes Dec 29, 2022
833f45c
Refactor remove/rename references to preflight checks in export.Servi…
gonzalo-bulnes Dec 29, 2022
e835f3b
Refactor remove/rename references to preflight checks in export.Servi…
gonzalo-bulnes Dec 29, 2022
bf80ff3
Refactor remove deprecated methods, rename for consitency
gonzalo-bulnes Dec 30, 2022
d6bcbbd
Add export.Service signal for clarity and consistency
gonzalo-bulnes Dec 30, 2022
a65b6d0
Refactor replace deprecated service tests
gonzalo-bulnes Dec 30, 2022
7b740a8
Refactor remove unnecessary export.Service injection
gonzalo-bulnes Jan 1, 2023
cd62bdd
Add test helpers for Qt testing
gonzalo-bulnes Jan 11, 2023
6515406
Add export.Disk
gonzalo-bulnes Dec 30, 2022
a9b2788
Add deprecated interface to export.Disk
gonzalo-bulnes Jan 2, 2023
8a8d8b0
Ensure export.Disk signals return no errors
gonzalo-bulnes Jan 2, 2023
94d7f0c
Add convenience function to reset export.Disk
gonzalo-bulnes Jan 2, 2023
9cf0f2f
Add convenience function to reset export.Service
gonzalo-bulnes Jan 3, 2023
16aa6ec
Refactor use export.Disk in export dialog
gonzalo-bulnes Jan 2, 2023
ca27689
Fix flaky test!
gonzalo-bulnes Jan 11, 2023
4480a41
Minor refactor move tests for readability
gonzalo-bulnes Jan 11, 2023
bd575de
fixup! Add export.Printer
gonzalo-bulnes Jan 11, 2023
3a1cdfa
Add deprecated interface to export.Printer
gonzalo-bulnes Jan 11, 2023
47888de
Refactor use export.Printer in print dialog
gonzalo-bulnes Jan 11, 2023
efe9a15
Add convenience function to reset export.Printer
gonzalo-bulnes Jan 12, 2023
add8960
Fix flakiness of tests involving Qt signals
gonzalo-bulnes Jan 12, 2023
bdd94e2
Revert "Revert "Refactor remove unused export.Device""
gonzalo-bulnes Jan 12, 2023
c77817e
Fix signal type hints
gonzalo-bulnes Jan 16, 2023
c634cee
Refactor rename methods to fix mistaken method override
gonzalo-bulnes Jan 16, 2023
afd18ec
Minor refactor simplify fixture
gonzalo-bulnes Jan 17, 2023
73d82ea
Refactor rename Disk.StatusLUKSEncrypted to StatusReachable
gonzalo-bulnes Jan 24, 2023
fbe4085
Minor refactor remove unnecessary comment
gonzalo-bulnes Jan 25, 2023
6d08613
Minor refactor group related statements for readability
gonzalo-bulnes Jan 25, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions securedrop_client/app.py
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@
from securedrop_client.logic import Controller
from securedrop_client.utils import safe_mkdir

export_service = export.getService()
gonzalo-bulnes marked this conversation as resolved.
Show resolved Hide resolved

LanguageCode = NewType("LanguageCode", str)

DEFAULT_LANGUAGE = LanguageCode("en")
Expand Down Expand Up @@ -246,11 +248,10 @@ def start_app(args, qt_args) -> NoReturn: # type: ignore [no-untyped-def]
main_queue_thread,
file_download_queue_thread,
]:
export_service = export.Service()
export_service.moveToThread(export_service_thread)
export_service_thread.start()

gui = Window(app_state, export_service)
gui = Window(app_state)

controller = Controller(
"http://localhost:8081/",
Expand Down
Loading