Revert "Remove unnecessary work around segmentation faults :)" #1656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gonzalo-bulnes
added
tests
馃崜 Bite-sized
It turns out that segmentation faults that I fixed were not the only cause of flakiness. I haven't found any obvious reason why timeouts would stop happening when tests run in isolation from each other, but that seems to work. Remains the occasional segfault, that should be the exception rather than a regular event. Restoring the workaround until it becomes worth investigating further. Trade-off: the functional tests are now 65% longer than the longest job in the pipeline, which extends the overall time accordingly. The regular failures did render the time-savings moot, so this actually making things better, just not as good as they would be without flakiness. This reverts commit a74c1ef.
gonzalo-bulnes
force-pushed
the
restore-functional-tests-flakiness-workaround
branch
from
fb37e1d
to
343abff
Compare
|
(rebased without changes) |
cfm
approved these changes
Apr 19, 2023
There was a problem hiding this comment.
Alas! But this looks good after three consecutive runs:
- CI is green, stays green if you re-build a few times (the occasional segfault is acceptable, but it should be a lot less frequent than we currently observe).
Thanks, @gonzalo-bulnes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Run the functional tests in isolation (one by one) again, to work around frequent timeouts that don't happen that way.
Details in the commit message! 馃挰
Test Plan