WIP: Use native Python functions instead of shelling out #1749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ypt). DRY up qrexec calling methods. Replace ExportStatus values with new values (see securedrop-export 80-support-veracrypt). Rename methods in export.py for clarity. Remove disk-test (combine disk-test and usb-test).
…sponsive to state of export workflow
…, print dialog, and Device.
… new functional test.
It now needs to emit the correct values rather than just returning statuses.
…eraCrypt drive and unlocking VC drive, using cryptsetup.
…either bad VC passphrase or corrupted drive). Add logic to detect and use VeraCrypt drives. Use new Status and Service for exporting files. Add method to cli.py to check all volumes and return most detailed information about each candidate Volume, including mounting if the volume is already unlocked.
…c test coverage. Changes to VC unlock logic and service.py to mount LUKS drive immediately after unlocking.
mypy noted a theoretical case in which `udisksctl mount` exits with a 0 status code but doesn't return our expected output. In this case just raise an exception as we couldn't figure out the mount point. While we're at it, add a test case to verify the mountpoint is parsed correctly.
I think this was just a mistake because the volume is already unmounted before the volume is closed.
This should hopefully fix CI and running in containers that don't have an active rsyslog daemon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP because tests are failing and this builds on top of #1669