Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Rust scaffolding #1817

Merged
merged 1 commit into from Feb 15, 2024
Merged

Add Rust scaffolding #1817

merged 1 commit into from Feb 15, 2024

Conversation

legoktm
Copy link
Member

@legoktm legoktm commented Feb 9, 2024 •
edited by cfm

Status

Ready for review

Description

This adds all the various configuration and tooling to have a proxy written in Rust.

Test Plan

  • CI passes
  • Visual review, compare with what SD server repo has

@legoktm legoktm marked this pull request as ready for review February 12, 2024 17:46
@legoktm legoktm requested a review from a team as a code owner February 12, 2024 17:46
@legoktm legoktm changed the title WIP: Add Rust scaffolding Add Rust scaffolding Feb 12, 2024
@legoktm legoktm mentioned this pull request Feb 12, 2024
Merged
2 tasks
@cfm
Copy link
Member

cfm commented Feb 15, 2024

Rebased from main after #1814. Reviewing while CI runs.

@legoktm @cfm
Add Rust scaffolding
21d282e 
This adds all the various configuration and tooling to have a
proxy written in Rust, some of which is copied from SecureDrop server.
cfm
cfm approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@cfm cfm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, @legoktm. By way of commentary, this is all pretty straightforward setup; securedrop's complexity comes in setting up the Rust toolchain also in the different containers.

@cfm cfm merged commit 9889db7 into main Feb 15, 2024
53 checks passed
@cfm cfm deleted the rust-init branch February 15, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cfm cfm cfm approved these changes

Assignees

@cfm cfm

Labels
None yet
Projects
SecureDrop dev cycle
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@legoktm @cfm