Fix for displaying quote based messages in conversation #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ultimatecoder
force-pushed
the
master-fix-broken-message-rendring
branch
from
a53625c
to
d5a2831
Compare
In conversation, messages with single quote (') or double quote(") quote
wasn't rendered correct. It was difficult for journalist to read those
messages. This commit is fixing that problem of parsing quote based
messages and improves readability of the text in the conversation.
Resolves: freedomofpress#175
| @@ -388,7 +388,7 @@ def __init__(self, text): | |||
| super().__init__() | |||
| layout = QVBoxLayout() | |||
| self.setLayout(layout) | |||
| message = QLabel(html.escape(text)) | |||
| message = QLabel(html.escape(text, quote=False)) | |||
There was a problem hiding this comment.
Works as expected, single and double quotes no longer escaped!
zenmonkeykstop
approved these changes
Nov 21, 2018
heartsucker
approved these changes
Nov 21, 2018
|
Thanks for the PR ✨ |
|
@heartsucker Thanks for reviewing 😄 |
legoktm
added a commit
that referenced
this pull request
Dec 15, 2023
Bump certifi dependency due to root certificate removal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: In conversation, messages with single quote ' or double quote " quote
wasn't rendered correct. It was difficult for journalist to read those
messages. This commit is fixing that problem of parsing quote based
messages and improves readability of the text in the conversation.
Resolves: #175
Video demonstration of this feature.