More dependabot config tweaks #1830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In <#1827 (comment)> it updated a production dependency, which we don't want. I'm not sure whether this will have an impact or whether it'll update it regardless since a dev dependency wants the newer urllib, we'll see.
These are pinned to the Debian versions and shouldn't be updated. Plus dependabot errors on them anyways (e.g. <https://github.com/freedomofpress/securedrop-client/network/updates/786279544>).
rocodes
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description
Refs #1823
Have dependabot ignore pyqt*
These are pinned to the Debian versions and shouldn't be updated. Plus
dependabot errors on them anyways (e.g.
https://github.com/freedomofpress/securedrop-client/network/updates/786279544).
Tell dependabot a bit harder we only want dev updates
In #1827 (comment)
it updated a production dependency, which we don't want. I'm not sure
whether this will have an impact or whether it'll update it regardless
since a dev dependency wants the newer urllib, we'll see.
Test Plan