Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move remaining CircleCI jobs to GitHub Actions #1841

Merged
merged 2 commits into from
Feb 21, 2024
Merged

Move remaining CircleCI jobs to GitHub Actions #1841

merged 2 commits into from
Feb 21, 2024

Commits on Feb 15, 2024

  1. Standardize make lint target in components

    In some places the `lint` target is just flake8 and in others it runs
    all linters. Adopt the latter definition to ensure that `make lint` runs
    all tools that don't run any code.
    legoktm committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    1dc4a4f View commit details
    Browse the repository at this point in the history
  2. Move remaining CircleCI jobs to GitHub Actions

    ci.yml's "component-lint" job runs `make lint` in all four components,
    and varies by Debian version (except proxy/bookworm).
    
    test.yml's "component" job runs `make test` in all components except
    client. The "client" job runs the test-functional, test-integration, and
    test-random targets and installs the extra dependencies needed (now in
    client/Makefile).
    
    test.yml also has "internationalization", which checks strings have been
    extracted and are reproducible.
    
    Some parts of GitHub's UI makes it inconvenient to have a ton of jobs in
    one file, so tests have been split out into their own for solely that
    reason.
    
    Dependencies that aren't needed were dropped as part of this (e.g.
    libnotify-bin, libmagic1, python3-dev, etc.). Same with the `export
    PYTHONPATH=$PYTHONPATH:.` pattern (the current directory is always on
    the Python path...).
    legoktm committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    3bc1e74 View commit details
    Browse the repository at this point in the history