Add shellcheck #1843
Merged
Add shellcheck #1843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rocodes
reviewed
Feb 22, 2024
Copy the `shellcheck.sh` script from the SecureDrop server repository and add it to the central `make lint` target. I added SC2164 as a global exclusion since we don't really care about `cd` potentially failing. The following fixes are being made: * client/.githooks/pre-commit: Use $() instead of backticks. * debian/setup-venv.sh: Ignore quoting words, all the variables are a single word only. * proxy/entrypoint.sh: Adjust shebang since we use bashisms. * scripts/build-debs.sh: Set variable and then export it * scripts/fixup-changelog.sh: Quote our variables, don't use `! -z`. Fixes #814.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description
Copy the
shellcheck.shscript from the SecureDrop server repository and add it to the centralmake linttarget. I added SC2164 as a global exclusion since we don't really care aboutcdpotentially failing.The following fixes are being made:
! -z.Fixes #814.
Test Plan