Stop running client tests in parallel with xdist #1881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfm
reviewed
Mar 4, 2024
There was a problem hiding this comment.
I'll note that the slowdown is more significant locally in than in CI: currently ~30 seconds for make test on main versus ~60 seconds on this branch. But overall I agree with your rationale here, @legoktm. I'll approve and merge tomorrow unless we hear from others today or tomorrow at stand-up.
These tests are pretty quick that they don't really benefit from xdist. Plus not all of our tests are threadsafe (e.g. the ones that call locale.setlocale()), so if there's no real need for parallelization, let's skip it. Refs #1880.
|
(Rebased) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description
These tests are pretty quick that they don't really benefit from xdist. Plus not all of our tests are threadsafe (e.g. the ones that call locale.setlocale()), so if there's no real need for parallelization, let's skip it.
Refs #1880.
Test Plan
test-integrationjob anyways