update FileWidget via signal emitted when file downloads + decrypts #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heartsucker
reviewed
Mar 27, 2019
There was a problem hiding this comment.
A couple of nits on the tests, but nothing that blocks. I do have a question though. Why is the signal named after "download" and not "ready?" Do we want users to be able to attempt to open if if the decryption fails? Or is there going to be a follow up to resolve that?
redshiftzero
force-pushed
the
emit-signal-file-download
branch
from
150a83d
to
5a15b6f
Compare
|
[ready for re-review] |
sssoleileraaa
approved these changes
Mar 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The traceback I reported in #266 was resolved with #231, but this addresses my comment here on that ticket about the FileWidget not updating after download.
Confirm the following to test this PR and confirm that #266 is resolved:
Closes #266