Handle messages and files that fail to decrypt #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
which we will then call from fetch_the_thing
do not remove files unless we've successfully decrypted them
redshiftzero
requested review from
sssoleileraaa and
heartsucker
as code owners
heartsucker
approved these changes
Apr 1, 2019
There was a problem hiding this comment.
Works as advertised. The nits about noqa feel like they should be addressed since we are disabling too many rules with that syntax and it may prevent us from catching bugs in the future. However, it is minor, so I'm approving. I'll let you decide if this is worth correcting or not.
|
During stand up we decided to make these changes so we could get this in while @redshiftzero is OOO. @creviera Can you review these two extra patches? |
sssoleileraaa
approved these changes
Apr 3, 2019
There was a problem hiding this comment.
I ran through the steps to reproduce in #276 on master and on download-then-decrypt and confirm that the fix works as documented with download endpoints only being hit once per file.
heartsucker
force-pushed
the
download-then-decrypt
branch
from
21a5dfe
to
ca48bb9
Compare
sssoleileraaa
approved these changes
Apr 4, 2019
| @@ -706,6 +707,7 @@ def test_find_new_replies(mocker, session): | |||
| session.add(reply_not_downloaded) | |||
| session.add(reply_decrypt_failed) | |||
| session.add(reply_decrypt_success) | |||
| session.commit() | |||
| @@ -661,6 +661,7 @@ def test_find_new_messages(mocker, session): | |||
| session.add(message_not_downloaded) | |||
| session.add(message_decrypt_failed) | |||
| session.add(message_decrypt_success) | |||
| session.commit() | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #276
Previously:
Now:
Test with STR in #276 and ensure that the
downloadendpoints are only hit once per file