Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no longer try to show conversation for deleted src #307

Merged
merged 1 commit into from Apr 17, 2019

Conversation

sssoleileraaa
Copy link
Contributor

Description

Fixes #302
Fixes #297
Fixes #195

Summary of Changes

  • on_source_changed now checks if the current source exists before trying to set the conversation
  • on_source_changed clears the conversation from the conversation view if the source does not exist
  • Removed calls to self.controller.session.refresh since it isn't necessary (might have been a fix for some bug that no longer exists)
  • We now show the number of replies being deleted in the popup that checks if the user wants to delete a source. Before we showed only counts for messages and files.

Test

  1. Log into the client
  2. Delete the first source by selecting 'x' next to the source in the source list and see conversation view cleared (app no longer crashes) after source and conversation are deleted
  3. Delete the second source using the source menu in the far upper-right corner and see conversation view cleared (app no longer crashes) after source and conversation are deleted
  4. See how conversation view is empty when the last source has been deleted

securedrop_client/logic.py Outdated Show resolved Hide resolved
securedrop_client/gui/main.py Outdated Show resolved Hide resolved
@sssoleileraaa sssoleileraaa force-pushed the issue-297-fix branch 2 times, most recently from e380f9c to 58c3720 Compare April 17, 2019 00:18
@sssoleileraaa sssoleileraaa marked this pull request as ready for review April 17, 2019 00:19
Copy link
Contributor

@redshiftzero redshiftzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff looks good now, I followed the test plan and all three bugs resolved as advertised! 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants