[type checking] add mypy to CI, resolve all current mypy errors #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redshiftzero
commented
Apr 19, 2019
heartsucker
reviewed
Apr 22, 2019
redshiftzero
force-pushed
the
type-checking
branch
3 times, most recently
from
4bc82c2
to
6737828
Compare
|
this one is ready for another peek @heartsucker or @creviera |
|
this lgtm, looking forward to the change |
sssoleileraaa
approved these changes
Apr 26, 2019
* ignore missing imports https://mypy.readthedocs.io/en/latest/running_mypy.html#ignore-missing-imports * mypy doesn't handle dynamic base classes see workaround in python/mypy#2477 * rework language_code handling to resolve TypeError mypy was flagging this logic due to the fact that current_locale is Optional[str] * TimedRotatingFileHandler delay arg should be bool
redshiftzero
force-pushed
the
type-checking
branch
from
6737828
to
d52db7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #25. This PR: