add SendReplyJob and use it for sending replies to the general queue #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sssoleileraaa
suggested changes
Jun 5, 2019
There was a problem hiding this comment.
When testing this, I noticed that the ReplyWidget for a new reply now disappears after sending it.
STR: 1. send reply, 2. click on a different source and back to the original source.
I can see that replies are being successfully sent, but it's almost like the GUI no longer receives the reply_succeeded signal. I see it in the code being sent but something's up.
redshiftzero
force-pushed
the
add-general-reply-queue
branch
from
75dd687
to
b09774f
Compare
|
dang, good catch: it was a familiar culprit - b09774f#diff-16a175b4662541f3889b432ac9e7e0e8R1393 |
two changes: 1. We should mark replies that we send as downloaded/decrypted so that we don't keep redownloading them. 2. We should refresh the source so that we get all items from the collection when we redraw it.
redshiftzero
force-pushed
the
add-general-reply-queue
branch
from
b09774f
to
8b9ec4c
Compare
|
ah, good point @creviera - addressed and squashed into last commit |
redshiftzero
moved this from In Development
to Ready for review
in SecureDrop Team Board
sssoleileraaa
approved these changes
Jun 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #390
Test Plan