add a DownloadJob class #409
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sssoleileraaa
force-pushed
the
issue-406-download-job
branch
from
82b655b
to
5939d2b
Compare
Merged
| except CryptoError as e: | ||
| set_object_decryption_status_with_content(db_object, session, False) | ||
| logger.debug('Failed to decrypt {}: {}'.format(db_object.filename, e)) | ||
| raise e |
There was a problem hiding this comment.
and then this exception gets handled in ApiJob._do_call_api ✅
| # are on Qubes, we should move the file to the data directory and name it the same as the | ||
| # server (e.g. spotless-tater-msg.gpg). | ||
| filepath_in_datadir = os.path.join(self.data_dir, server_filename) | ||
| shutil.move(file_path, filepath_in_datadir) |
There was a problem hiding this comment.
where is this being done now? (the file download logic won't work on Qubes otherwise) also let's preserve the above comment since otherwise it's not obvious why this file moving is being done
There was a problem hiding this comment.
Whoops! Don't know how I missed that comment! Yes, will add back and test on qubes.
This was referenced Jun 14, 2019
Merged
Merged
|
closing because this was broken down into several PRs: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #406
Behavior should remain the same. This adds a lot of new tests and an API download base class.
Test Plan