update pip mirror update policy, build deb package on each PR to verify policy is adhered to #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[and when we merge we'll need to modify the required checks in this repo from |
redshiftzero
changed the title
redshiftzero
changed the title
redshiftzero
force-pushed
the
update-pypi-on-pr
branch
from
f62261b
to
aedb74f
Compare
this intentionally does not commit and tag as I want to run non-interactively
redshiftzero
force-pushed
the
update-pypi-on-pr
branch
from
aedb74f
to
eb47273
Compare
redshiftzero
changed the title
|
this is ready for review, build is passing |
|
(I'm going to hold off on making changes to the corresponding wip PR in securedrop-proxy (freedomofpress/securedrop-proxy#36) until at least the general approach here is approved) |
kushaldas
approved these changes
Jun 18, 2019
There was a problem hiding this comment.
That update_version.sh is a fancy work @redshiftzero 👏 Approved. Tested on my local system.
This was referenced Jun 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes in this repo for freedomofpress/securedrop-builder#48
Closes #126
Test Plan
CI/dev only so read the diff, make sure all makes sense, and ensure CI build and test jobs pass