Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 432 fix #434

Merged
merged 2 commits into from Jun 25, 2019
Merged

Issue 432 fix #434

merged 2 commits into from Jun 25, 2019

Conversation

sssoleileraaa
Copy link
Contributor

@sssoleileraaa sssoleileraaa commented Jun 25, 2019 •
edited

Description

Fixes #432

Test Plan

  1. Checkout master branch, send a reply on Qubes against an app server running SD version 0.13.0 or SD version 0.13.1 with this line of code commented out, and see the app crash.
  2. Checkout this PR branch, send a reply on Qubes, and see that the app no longer crashes. Also look for the log message that the reply failed to send.

kushaldas
kushaldas approved these changes Jun 25, 2019
View reviewed changes
Copy link
Contributor

@kushaldas kushaldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as suggested. In future we would want to mark reply which failed to go out.

@kushaldas kushaldas merged commit d887370 into master Jun 25, 2019
@kushaldas kushaldas deleted the issue-432-fix branch June 25, 2019 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kushaldas kushaldas kushaldas approved these changes

@heartsucker heartsucker Awaiting requested review from heartsucker

@redshiftzero redshiftzero Awaiting requested review from redshiftzero

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SendReplyJob failures
2 participants
@sssoleileraaa @kushaldas