remove now unnecessary QApplication.processEvents calls #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're not running this queue in the GUI thread so we shouldn't need to explicitly call processEvents. And testing for stale mocks should not be needed here as the mocker.patch fixture cleans up unused mocks after each test runs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #419. @creviera is correct: since we're not running this queue in the GUI thread, events will be processed without needing to explicitly call
QApplication.processEvents.Test Plan
You can verify for yourself that events are being processed by checking out this diff, adding a
time.sleep(5)at the end of the queue loop here and running the application. You'll see each job finish and the UI update as expected after each job.Checklist
If these changes modify code paths involving cryptography, the opening of files in VMs, network (via the RPC service) traffic, or fine tuning of the graphical user interface, Qubes testing is required. Please check as applicable: