update font weights to numbers and match zeplin #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sssoleileraaa
force-pushed
the
moar-fonts
branch
2 times, most recently
from
b2a1650
to
9a7a102
Compare
sssoleileraaa
moved this from In Development
to Ready for review
in SecureDrop Team Board
redshiftzero
suggested changes
Aug 2, 2019
sssoleileraaa
force-pushed
the
moar-fonts
branch
from
9a7a102
to
094a9ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Towards #438
Resolves #492 and while updating weights to match zeplin, I updated colors, and sizes to match zeplin as needed (since I was already closely looking at so many fields in zeplin)
Note: some colors and fonts do not look exactly the same because of how zeplin has styled many fonts to use different letter spacing, font stretch, shadowing, and line height. This work has been moved to a separate issue which will be tracked in #438
See results:
Checklist
If these changes modify code paths involving cryptography, the opening of files in VMs, network (via the RPC service) traffic, or fine tuning of the graphical user interface, Qubes testing is required. Please check as applicable: