Show/hide instructions in USB passphrase dialog depending on bad_passphrase #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sssoleileraaa
requested review from
kushaldas and
redshiftzero
as code owners
eloquence
changed the title
redshiftzero
approved these changes
Oct 15, 2019
|
Hey gang, that's a bit of a mouthful. What is the context for this, Allie? On an aside, the general best-practice for messaging is to first tell the user what to do, then why; keeping it as simple as possible. "Provided passphrase" is a tongue-twister, and feels like an excess of characters to communicate a simple thing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Small PR to fix bug with showing two sets of instructions for after a bad passphrase.
Messaging before:
Messaging now: